update uses of messageHash and rawTransaction from eth-account to snakecase version per eth-account v0.12.2

ethereum / web3.py

A python interface for interacting with the Ethereum blockchain and ecosystem.

http://web3py.readthedocs.io

MIT License

4.97k stars 1.7k forks source link

update uses of messageHash and rawTransaction from eth-account to snakecase version per eth-account v0.12.2 #3348

Closed pacrob closed 5 months ago

pacrob commented 5 months ago

What was wrong?

eth-account v0.12.2 deprecated messageHash for message_hash and rawTransaction for raw_transaction.

How was it fixed?

Changed all examples to use the snakecase version. In one example in web3.eth.account.rst, both messageHash and message_hash keys are present.

Todo:

[x] Clean up commit history
[x] Add or update documentation related to these changes
[x] Add entry to the release notes

Cute Animal Picture

pacrob commented 5 months ago

This needs to go be merged into v6, right? And v7 / main will have the new version of eth-account with the removals?

v6 has its own version getting worked. This is failing now, but I think yes, once eth-account v0.13.0 is released, we can bottom pin that here and remove the stray messageHash from the doctest.

kclowes commented 5 months ago

We will need to make the eth-account version here >0.12.2