Update provider explicit exports

ethereum / web3.py

A python interface for interacting with the Ethereum blockchain and ecosystem.

http://web3py.readthedocs.io

MIT License

4.97k stars 1.69k forks source link

Update provider explicit exports #3409

Closed fselmo closed 4 months ago

fselmo commented 4 months ago

What was wrong?

closes #3396 together with #3410

How was it fixed?

Adds AsyncEthereumTesterProvider to web3/__init__.py.
Adds EthereumTesterProvider and AsyncEthereumTesterProvider to web3/providers/__init__.py.
Update __all__ in web3/__init__.py to include all provider classes, including base classes.
Add __all__ for web3/providers/__init__.py including all explicit exports.

Todo:

[x] Clean up commit history
[x] Add entry to the release notes

Cute Animal Picture

20240529_124042

fselmo commented 4 months ago

LGTM! Do we need to export __all__ in other __init__ too? like in #3402?

Ah, I missed that PR. Yeah, I think that's nice to have. I will rebase off of it and add the missing exports after the fact.

fselmo commented 4 months ago

@kclowes rebased off #3402. My only remaining questions are whether things like combine_middleware, re-exporting Web3 even though it's only used internally in places like web3/middleware/__init__.py, etc are desired. I lean towards a no on that but can also leave it as it was in #3402.

kclowes commented 4 months ago

No, I don't think we want to re-export Web3 or export combine_middleware