Use owning classe instance when generating session cache keys: - Githubissues

ethereum / web3.py

A python interface for interacting with the Ethereum blockchain and ecosystem.

http://web3py.readthedocs.io

MIT License

4.89k stars 1.67k forks source link

Use owning classe instance when generating session cache keys: #3411

Closed fselmo closed 1 month ago

fselmo commented 1 month ago

What was wrong?

We need a unique identifier per instance of Web3, HTTPProvider, or Beacon when generating session cache keys. Pass this value as a kwarg when available in order to create unique cache keys.
The same as the above is true for the async counterparts.

Closes #3265

How was it fixed?

If request methods are called from within a class, use this owning_class instance to generate a unique session cache key for the url, along with the threading id.

Todo:

[ ] Clean up commit history
[ ] Add entry to the release notes

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

fselmo commented 1 month ago

closing for now in favor of unique RequestSessionManager instances for http providers.