Run mypy with all deps installed - Githubissues

ethereum / web3.py

A python interface for interacting with the Ethereum blockchain and ecosystem.

http://web3py.readthedocs.io

MIT License

4.89k stars 1.67k forks source link

Run mypy with all deps installed #3414

Open pacrob opened 1 month ago

pacrob commented 1 month ago

What was wrong?

Running mypy via the pre-commit mirrors-mypy hook misses the context of other libs in our dependencies.

How was it fixed?

Update the pre-commit mypy hook to run locally.
Bump requests dep to >=2.23.0, where they first support py38
Add types-requests>=2.0.0 to install_requires deps

fix all the new mypy errors!

Todo:

[ ] Clean up commit history
[ ] Add or update documentation related to these changes
[ ] Add entry to the release notes

Cute Animal Picture