search

ethereum / web3.py

A python interface for interacting with the Ethereum blockchain and ecosystem.
http://web3py.readthedocs.io
MIT License
4.97k stars 1.7k forks source link

Vyper decimal10 abi type support #700

Closed djrtwo closed 6 years ago

djrtwo commented 6 years ago

What was wrong?

There is currently no support for vyper abi type decimal10. Although vyper is in alpha, it is increasingly used by ethereum research team for casper and sharding.

How can it be fixed?

Add support for decimal10 abi type :)

djrtwo commented 6 years ago

This is on my to-do list but I'm not sure when I will get to it. If someone else begins development on it, just let me know here.

pipermerriam commented 6 years ago

cc @davesque can you get this issue duplicated in the eth-abi repository. I think this is higher priority than the tuple type work that I initially pointed you at.

I think this also suggests prioritizing https://github.com/ethereum/eth-abi/issues/36 ahead of tuple types might also be beneficial so that it's easier for 3rd party encoders/decoders to be written without requiring a core change to the eth-abi library.

davesque commented 6 years ago

@pipermerriam Sure no problem. Sorry I missed this the other day.

davesque commented 6 years ago

eth-abi issue: https://github.com/ethereum/eth-abi/issues/39

carver commented 6 years ago

So almost all of the work will happen in eth-abi#39, but I'll leave this one open until we upgrade eth-abi in web3.

carver commented 6 years ago

I suspect we'll be seeing Vyper switch to fixedMxN based on https://github.com/ethereum/vyper/issues/566

Continuing to leave this issue open until that's confirmed.

dylanjw commented 6 years ago

Vyper included the switch from decimal10 to fixed168x10 in https://github.com/ethereum/vyper/pull/815