search

ethereum / wiki

The Ethereum Wiki
https://www.ethereum.org
14.75k stars 2.56k forks source link

shouldn't you remove sendRawTransaction for sendSignedTransaction? #611

Closed lebed2045 closed 6 years ago

lebed2045 commented 6 years ago

all new versions, supposedly since supposedly 2016 uses sendSignedTransaction function so we should use web3.eth.sendRawTransaction || web3.eth.sendSignedTransaction; to make it work locally and on heroku. Same with let toHexF = web3.toHex || web3.utils.toHex; which is inconvenient to say at least. If the documentation will have actual information and explanation what happened in which version - would be better.

SongJayJay commented 6 years ago

sendSignedTransaction is great，it can be understood literally

lebed2045 commented 6 years ago

@songyuanjie I do agree, however, the fact that web3@0.2.x and web3@1.x have different interface can be emphasized more clear on the documentation. For example, put in the title like web3@0.2 Latest stable Version.

jamesray1 commented 6 years ago

See https://github.com/ethereum/wiki/wiki#issues-and-pull-requests, file an issue in the web3 repo. This is for the wiki only not everything related to Ethereum. If you see an issue with web3 docs here please preferably still file that with the web3 team.