search

ethereum / wiki

The Ethereum Wiki
https://www.ethereum.org
14.75k stars 2.56k forks source link

[Docs] parameter order for web3.eth.sign() #620

Closed hudsonburgess closed 4 years ago

hudsonburgess commented 6 years ago

https://github.com/ethereum/wiki/wiki/JavaScript-API#web3ethsign

The signature is listed as

web3.eth.sign(address, dataToSign [, callback])

But the example is

var result = web3.eth.sign(
    "0x9dd2c369a187b4e6b9c402f030e50743e619301ea62aa4c0737d4ef7e10a3d49", // first argument is web3.sha3("xyz")
    "0x135a7de83802408321b74c322f8558db1679ac20");

Which parameter is actually first -- address or dataToSign?

jamesray1 commented 5 years ago

Please see https://github.com/ethereum/wiki/blob/master/ISSUE_TEMPLATE.md.

ChrisChinchilla commented 4 years ago

Closed in https://github.com/ethresearch/eth-wiki/issues/18