Open bendyarm opened 6 years ago
The second reference in Appendix F also seems wrong. It is referring to a work that describes research on SHA-256, not SECP-256k1 (btw, usually written "secp256k1", not "SECP-256k1") Same commits as above. I suggest removing this reference, too.
The third reference in Appendix F also seems wrong. The paper https://www.iacr.org/archive/ches2004/31560117/31560117.pdf doesn't refer to any of the Koblitz curves, in particular, not secp256k1. I suggest updating this. I will add a comment with a suggested replacement.
Here's a suggested replacement for the first paragraph:
Transactions are signed using the Elliptic Curve Digital Signature Algorithm (ECDSA) [Brown [2009]]. The specific elliptic curve parameters are defined by secp256k1, as standardized by ANSI, IEEE, and others as described in [Brown [2010]]. The same algorithm and parameters are used to sign Bitcoin transactions [Casascius et al. [2011]].
Brown [2009] is: Standards for Efficient Cryptography 1 (SEC 1) URL: http://www.secg.org/sec1-v2.pdf
Brown [2010] is: Standards for Efficient Cryptography 2 (SEC 2) URL: http://www.secg.org/sec2-v2.pdf
Casascius et al. [2011] is: URL: https://en.bitcoin.it/wiki/Secp256k1
This is bad, but thanks for the chance of removing the cargo cult.
Looking at the web site in the reference "Arnaud et al. [2017]", in Appendix F, it seems to me to be a different "electrum", namely a React component tool called "electrum", not the wallet called "electrum".
Here are two relevant commits: https://github.com/ethereum/yellowpaper/pull/607/commits/570baa3e0a95e81d5b1025527ec9d9839ab7c9d0 https://github.com/ethereum/yellowpaper/pull/607/commits/e3b5f5af3b1b34212b0f8d08f8cff54979d1935e The reference is oddly specific, referring to 'heading “Managing styles with Radium” in the bullet point list.' But that heading discusses UI Button styles, not 'Electrum style signatures'. I suggest removing this reference altogether.