ethereumclassic / ethereumclassic.github.io

Ethereum Classic Website
https://ethereumclassic.org
Other
179 stars 231 forks source link

Add ETCswapV3 material: Announcement Article, App Icon, Stablecoin, Update V2 and WETC #1510

Closed etc-contribunator[bot] closed 4 months ago

etc-contribunator[bot] commented 5 months ago

This adds:

Articles Titled

Introducing ETCswap v3 (May 6th) Introducing Ethereum Classic USD-Backed 'USC' Stablecoin (May 14th)

Article URL

Author Name

Ethereum Classic DAO

Source Name

EthereumClassic.com

Tags

Announcements, Development, Education, Exchanges, Guides

Apps Titled

netlify[bot] commented 5 months ago

Deploy Preview for ethereumclassic ready!

Name Link
Latest commit 96ccfb0dcd43e1e44e879c9771ec895d3c7e3c5a
Latest deploy log https://app.netlify.com/sites/ethereumclassic/deploys/664345e6f947a70008cd7a2b
Deploy Preview https://deploy-preview-1510--ethereumclassic.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

IstoraMandiri commented 4 months ago

This should be added into the apps section rather than as a news item. Apps will be listed in the news feed and RSS and, with a logo will appear more this way.

The announcement link can be included as a generic link in the app info.

https://etc.contributions.app/contribute/ethereumclassic.github.io/app

chris-mercer commented 4 months ago

This should be added into the apps section rather than as a news item. Apps will be listed in the news feed and RSS and, with a logo will appear more this way.

The announcement link can be included as a generic link in the app info.

https://etc.contributions.app/contribute/ethereumclassic.github.io/app

Hey @IstoraMandiri thanks for the feedback, I will update to add two separate App Section listing since they are two different protocols.

This articles is an announcement article with a product guide, so I think its fitting for submission as an external link in the new rss feed. Also I think it makes sense to make product specific content come from external links opposed to internal .org blog posts. So I'm trying to set the best practices here opposed to these type of article that are coming out of the .org blog.

Notice how these are internal articles, as previously mentioned when solicitation began in the articles through @DonaldMcIntyre , I think this is confusing to the end user. I think external links makes a whole lot more sense for this type of content. But I'm also happy to follow the process currently in place and draft an internal article if needed. https://ethereumclassic.org/blog/2023-06-20-etc-ecosystem-spotlight-hebeswap-part-i/ https://ethereumclassic.org/blog/2023-07-04-etc-ecosystem-spotlight-hebeswap-part-ii/ https://ethereumclassic.org/blog/2023-12-13-etc-ecosystem-spotlight-creating-fair-launch-erc-20-tokens-on-etcinscribe/

chris-mercer commented 4 months ago

"I'll get to approving today, just on mobile ATM" - Istoria

This has approval from Istoria as its met all of his requests, however he is on mobile. So I'm going to push it since its been open for a week, gone through peer review, and this is synced up to the release of some paid articles.

IstoraMandiri commented 4 months ago

"I'll get to approving today, just on mobile ATM" - Istoria

"I'll get to approving" doesn't mean "this is approved, please approve on my behalf".

I wasn't able to review it properly as I was on mobile.

Now I'm back to desktop I can see that it shouldn't have been approved/merged, as the use of external links will skip the disclaimers that the other ETC Spotlight articles have. Scanning the issue on mobile, I assumed you were going to copy the format of the other ETC Spotlight articles.

Notice how these are internal articles, as previously mentioned when solicitation began in the articles through @DonaldMcIntyre , I think this is confusing to the end user. I think external links makes a whole lot more sense for this type of content. But I'm also happy to follow the process currently in place and draft an internal article if needed.

We had this discussion previously regarding ETC Spotlight articles, which are internal so that we can control ensure that disclaimers are present.

https://github.com/ethereumclassic/ethereumclassic.github.io/pull/1260

Please could you convert these links to blog posts to follow the ETC Spotlight format?