Closed IstoraMandiri closed 4 months ago
Name | Link |
---|---|
Latest commit | d62d73f24eee153abd37ce241be4bb61c5be6119 |
Latest deploy log | https://app.netlify.com/sites/ethereumclassic/deploys/6643d60ea17c2a0008ce3f7d |
Deploy Preview | https://deploy-preview-1517--ethereumclassic.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
If the external links are converted to standard ETC Spotlight blog posts, this issue can be closed.
Why are you requiring the announcement be internal "ETC Spotlight" blog posts? You required us to change the Title to "ETC Spotlight" this was not what we wanted, we just wanted the announcement articles in the external feed like the ETC Grants DAO announcement and everything else.
Would you like the announcement article title adjust back to their original titles? I'm confused as you all of your requirements for us submitting external article links. But I've tried to met all your requests.
You want us to draft these as internal blog posts now? But why?
https://ethereumclassic.org/news/tag/external
The PR was submitted because it was mentioned if we changed the title you could approve after this time sensitive note:
"@Istora @Donald McIntyre can you guys get this out on the 14th. It will sync up with some paid articles and stuff. Thanks in advance!"
"Istora @ronin thanks for updating, can you "Ecosystem Spotlight" to the title/url to follow the same format as before? Then I can approve"
then in Dm you mentioned you were on mobile. I saw it this morning, all changes you request were done and the PR was pushed with a comment citing your unavailability to submit approval due to the mobile note. The original PR has also been open since May 6th.
Issue communicated and resolved in the discord. The request is the articles be drafted as internal articles, opposed to external articles. Just some minor confusion in communication and purpose of external articles and internal articles.
Easy resolution and there will be a PR published tonight to adjust to internal blog articles with links to external articles.
Cool, then closing this to avoid confusing.
Reverts ethereumclassic/ethereumclassic.github.io#1510
This PR should not have been merged as it diverges from neutrality precedents (ETC Spotlight).
It was also approved by it's own author ( @gitr0n1n / @chris-mercer ), which skipped a third party approval step (in practice only one 3rd party approval from @DonaldMcIntyre, there should always be two).
If the external links are converted to standard ETC Spotlight blog posts, this issue can be closed.