Various improvements ( tx page, sync, load ) & codebase cleanup

ghost commented 5 years ago

Ready to merge

Breaking Changes

Modification on DB, need resync to reflect information
Upgraded to web3 1.0, node connection changed to WebSocket ( please open WebSocket connection on your node side)
Requires https://coinmarketcap.com/api/ account & api_key value to sync price info

Changelog

[x] Upgraded to web3 1.0, now supports more tx information with faster sync & load speed! ( About 10x faster than http rpc )
[x] Fetch ERC20 tokens & Contracts from network, record them on DB
[x] eslint & html-linter added to improve collaborative environment for decentralized buiild.
[x] Improve web3relay by fetching tx information from DB
[x] Add FIAT exchange for addresses and tx
[x] Drop dao / bomb-chart support for lower priority
[x] Add documentation about mongodb authentication
[x] Enforce lowercase on transactions & accounts
[x] Bug fixes & small improvements

Preview

Capture

Demo page

https://classic.btenterprise.io/home

Donation

If you would like to support my work here is my tip jar.

ETC: 0xbfb05c94cde31adcc85636a5faa15d6e8f03478e

tested on local environment

cc @realcodywburns @pyskell @hackmod

ghost commented 5 years ago

PR finalized for now, will commit more on next PR!

Please make a review

phyro commented 5 years ago

I advise you open a smaller PR next time, it's quite hard to review such big PRs. I've not tested it locally, I briefly skimmed over the code for now and did not find a malicious attempt (should be checked also by others as well). Thanks for the docker-compose

ghost commented 5 years ago

Wasn't possible to open with smaller PRs, merging conflicts and the pr is a big clean up so :) ( Will be same if we have eslint for PR )

ghost commented 5 years ago

@mikeyb I believe this PR is finalized and ready to go 🎉

hackmod commented 5 years ago

web3.js 1.0 is not matured. It is beta state. we don't have to hurry to use web3 1.0 at all https://github.com/ethereum/web3.js/releases

ghost commented 5 years ago

@hackmod In that perspective Web3 0.20.x version is deprecated and unsecure https://medium.com/@samuel_91690/web3-js-v1-0-0-beta-38-8d2bb6e73d0b ,

stealing the web3 maintainer's word:

The version 0.20.x is in maintenance mode since 19.04.2018 and just got security updates and smaller bug fixes. Because of the coming stable release of the library, I’ve deprecated version 0.20.x and recommend switching to version 1.0.0-x of the library if you have not already. Further details of the roadmap of the library are explained below.

ghost commented 5 years ago

I've used web3 1.0 cause they are being used on truffle, ganache-cli , mist, and metamask. If web3 1.0 is not matured, why are they using it?

ghost commented 5 years ago

Demo page is now live https://classic.btenterprise.io.

Anyone still not willing to review or merge? What am I contributing for? 😂

hackmod commented 5 years ago

etc explorer use parity heavily. we have to make new dev branch like as web3-1.0 or something it causes break all parity behaviors.

ghost commented 5 years ago

@hackmod What do you mean? I am using Parity. Parity works completely fine with web3, I think you must check your configuration.

hackmod commented 5 years ago

ok. I see now. you've extract parity extension stuff to the web3-explorer. https://github.com/btenterprise2020/web3-explorer.js/blob/master/index.js

why are you trash all batch job stuff with no reason?

ghost commented 5 years ago

Batch job is no longer necessary for web3 1.0, if you want them please make a pr.

hackmod commented 5 years ago

and do not rebrand original npm package https://github.com/axic/web3-complete.js

ghost commented 5 years ago

@hackmod If you have any more further questions, just let me know at DM. We have no reason to spam here. Thanks.

ethereumclassic / explorer