Validate blocks correctly for all known hardforks

ethereumjs / ethereumjs-block

Project is in active development and has been moved to the EthereumJS VM monorepo.

https://github.com/ethereumjs/ethereumjs-vm/tree/master/packages/block

Mozilla Public License 2.0

42 stars 49 forks source link

Validate blocks correctly for all known hardforks #47

Closed vpulim closed 6 years ago

vpulim commented 6 years ago

Fix for https://github.com/ethereumjs/ethereumjs-block/issues/46

Added branching logic in BlockHeader.canonicalDifficulty() to use the correct difficulty formula based on which hardfork the block is in
Added additional test data to test all hardforks and chains (copied from https://github.com/ethereum/tests/tree/develop/BasicTests)

coveralls commented 6 years ago

Coverage increased (+0.8%) to 73.234% when pulling 4451ac12a18828bd1518e0076fe08be6770337b2 on multiple-hardfork-support into 31598494e4de5a5853e9ee2ac429dd738909ebb9 on master.

holgerd77 commented 6 years ago

Should be good for a release, shouldn't it? Or do you plan to add other stuff you want to have included? What are your feelings about a release number, 2.0 or rather 1.8 (I've got a 2.0 tendency I think)?

vpulim commented 6 years ago

No plans to add anything else. Feel free to release!

I think 2.0 makes sense.