[Constantinople] Added difficulty bomb delay (EIP1234)

ethereumjs / ethereumjs-block

Project is in active development and has been moved to the EthereumJS VM monorepo.

https://github.com/ethereumjs/ethereumjs-vm/tree/master/packages/block

Mozilla Public License 2.0

42 stars 49 forks source link

[Constantinople] Added difficulty bomb delay (EIP1234) #54

Closed alextsg closed 5 years ago

alextsg commented 6 years ago

Fixes #53

alextsg commented 6 years ago

@holgerd77 I'm not sure what's the best way to add tests here, as I don't think difficultyConstantinople.json exists yet on ethereum/tests.

coveralls commented 6 years ago

Coverage increased (+0.5%) to 73.818% when pulling d9de788854f11540b8308c5460a7a49d9a83d279 on alextsg:eip1234 into dbe2ffb10b27c7e81888a352d8a97a22a0cd94fa on ethereumjs:master.

holgerd77 commented 6 years ago

Hmm, not sure, have asked here: https://github.com/ethereum/tests/issues/318

There is also this spreadsheet with the state of tests, difficulty section seems to be outdated though.

alextsg commented 6 years ago

Thanks @holgerd77. It sounds like tests are coming soon so I'll keep a lookout for that.

holgerd77 commented 5 years ago

Difficulty tests for Constantinople are now merged, see new difficultyConstantinople.json file over on the ethereum/tests repo, so we can use this now for testing here in the library.

holgerd77 commented 5 years ago

Hi @alextsg, I've now also released a new version v0.6.0 of the ethereumjs-common library including the miner reward parameter changes PR.

alextsg commented 5 years ago

Great, thanks @holgerd77! Will finish this up soon.

holgerd77 commented 5 years ago

Hi Alex, if you could update here would be great, then we could finish this part up! 😃

alextsg commented 5 years ago

Sorry about that! Updated