search

ethereumjs / ethereumjs-block

Project is in active development and has been moved to the EthereumJS VM monorepo.
https://github.com/ethereumjs/ethereumjs-vm/tree/master/packages/block
Mozilla Public License 2.0
42 stars 49 forks source link

Remove ethereumjs-testing dependency #55

Closed holgerd77 closed 5 years ago

holgerd77 commented 5 years ago

Currently the very heavy (several 100 MB) ethereumjs-testing version is pulled into the library (over and above in an outdated version) and just used to include a single file with const testDataGenesis = testing.getSingleFile('BasicTests/genesishashestest.json') in block.js and header.js test files.

This should be replaced by a static copy-and-paste approach like being done for the difficulty files and the dependency should be removed.

The copied over file from the tests repository should be extended with a structure:

{
  "source": "https://github.com/ethereum/tests/blob/develop/BasicTests/genesishashestest.json",
  "commit": "149cc9b",
  "date": "2018-10-12",
  "tests": {
  }
}

so that it is becoming clear where this is coming from and what version has being used.

holgerd77 commented 5 years ago

Update: changed the outer JSON structure slightly from a generic "comment" field to separated "source", "commit" and "date" fields.