search

ethereumjs / ethereumjs-blockchain

Project is in active development and has been moved to the EthereumJS VM monorepo.
https://github.com/ethereumjs/ethereumjs-vm/tree/master/packages/blockchain
121 stars 63 forks source link

An in-range update of tape is breaking the build 🚨 #56

Closed greenkeeper[bot] closed 6 years ago

greenkeeper[bot] commented 6 years ago

Version 4.9.1 of tape was just published.

Branch Build failing 🚨
Dependency tape
Current Version 4.9.0
Type devDependency

This version is covered by your current version range and after updating it in your project the build failed.

tape is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details - ❌ **continuous-integration/travis-ci/push** The Travis CI build failed [Details](https://travis-ci.org/ethereumjs/ethereumjs-blockchain/builds/389489383?utm_source=github_status&utm_medium=notification)
Commits

The new version differs by 10 commits.

  • 050b318 v4.9.1
  • 73232c0 [Dev Deps] update js-yaml
  • 8a2d29b [Deps] update has, for-each, resolve, object-inspect
  • c6f5313 [Tests] add eclint and eslint, to enforce a consistent style
  • 45788a5 [Dev Deps] update concat-stream
  • ec4a71d [fix] Fix bug in functionName regex during stack parsing
  • 7261ccc Merge pull request #433 from mcnuttandrew/add-trb
  • 6cbc53e Add tap-react-browser
  • 9d501ff [Dev Deps] use ~ for dev deps; update to latest nonbreaking
  • 24e0a8d Fix spelling of "parameterize"

See the full diff

FAQ and help There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new).

Your Greenkeeper Bot :palm_tree:

greenkeeper[bot] commented 6 years ago

After pinning to 4.9.0 your tests are still failing. The reported issue might not affect your project. These imprecisions are caused by inconsistent test results.

vpulim commented 6 years ago

I think build is breaking due to this ethjs-util PR being merged a few hours ago: https://github.com/ethjs/ethjs-util/pull/7

That PR seems to have broken the intToBuffer() function. It is now returning an empty Buffer for numbers smaller than 16. Will look into this further and file an issue with ethjs-util soon.

vpulim commented 6 years ago

I submitted a PR to ethjs-util to fix this issue and it's been merged. The build should now be working.