search

ethereumjs / ethereumjs-blockstream

Reliable stream of Ethereum blocks
MIT License
80 stars 18 forks source link

Deprecates callback style interface. #14

Closed MicahZoltu closed 6 years ago

MicahZoltu commented 6 years ago

Gets rid of the legacy style examples and adds a deprecation warning to the callback style entrypoints.

If you want callback style, use one of the many promise<->callback wrappers on the internet (though I strongly recommend just using async/await instead).

This change is being made because maintaining two interfaces is more expensive than maintaining one, and the legacy interface really shouldn't be used now that async/await is available everywhere (all major browsers and LTS version of NodeJS).

tinybike commented 6 years ago

You monster!!!!!

MicahZoltu commented 6 years ago

Note: You can grab version 4.0.0 if you want everything except this deprecation warning. Be aware that you won't get future updates until you accept the deprecation though. 😁