search

ethereumjs / ethereumjs-monorepo

Monorepo for the Ethereum VM TypeScript Implementation
2.58k stars 750 forks source link

Monorepo: KZG/Kzg Naming Inconsistencies #3656

Open holgerd77 opened 1 week ago

holgerd77 commented 1 week ago

Guess we want the same as in #3632 for KZG (so: Kzg -> KZG + add to spell check)! 😋

@gabrocheleau Can you do that (as well)? 🙂

gabrocheleau commented 1 week ago

One limitation for KZG renaming will be that some of the actual methods live in another package (https://github.com/ethereumjs/kzg-wasm) @acolytec3 would you be able to do the renaming on that side & publish a new release? I can then update the monorepo dep and adjust.

acolytec3 commented 16 hours ago

What should we do with this issue/PR. The new kzg library in micro-eth-signer we're using still has one instance of blobToKzgCommitment and that is reflected in our interface so we don't have to carry a wrapper construct around everywhere. Can we be content with that one discrepancy and make KZG capitalized everywhere else it appears?