search

ethereumjs / ethereumjs-monorepo

Monorepo for the Ethereum VM TypeScript Implementation
2.6k stars 756 forks source link

Move over verkleCrypto handling into common #3774

Open gabrocheleau opened 3 days ago

gabrocheleau commented 3 days ago

We currently are in a situation where we are passing verkleCrypto around in the VM/EVM/StateManager. With the latest AccessWitness work from #3770, we are now getting the verkleCrypto instantiation from stateManager, which is a bit roundabout and counterintuitive. As suggested by Holger in this comment: https://github.com/ethereumjs/ethereumjs-monorepo/pull/3770#discussion_r1818569641, we could instead move it into Common.

holgerd77 commented 3 days ago

Ok, I think I remember that the main argument @acolytec3 had against this is that we would need Common to be added to the Verkle library. 🤔

Guess I am still somewhat in favor, might become necessary in the future along additional Verkle HFs anyhow and Common is in many cases already there and therefore also easily be used to carry this Verkle crypto around as we do with the other stuff.