Closed rumkin closed 4 years ago
The level
dependency is used in the blockchain test runner which passes on an instance to the Blockchain
object as its DB.
ethereumjs-blockchain
is using level-mem
with a v3.0.1
dependency (see package.json), so also an older version.
I think it would make sense to keep this (relatively) in sync rather than update on one side and do an update both on the VM
and Blockchain
in one PR once we have both libraries together in the monorepo, what do you think @evertonfraga @ryanio?
Level-family packages has the same interface and AFAIK backward compatible interfaces, so it seems safe and reliable to update only a single package. This update is required to fix node native package installation issue and as you can see in PR #662 all tests passed well even with the current level-mem
. Current version of level breaks the installation so it seems reasonable to fix this and add an issue for mono-repo to update the rest of level related things.
Ok, that makes sense. Not that much of a level expert and always unsure on how conservative to be here in updates.
Seems sensible to me to pack changes together in the monorepo.
@evertonfraga There should be a label package: blockchain
too, could you add this? I'm going to update package level-mem
for it. Can I do it now, or there is still migration in progress?
Fixed by #662
Development version of VM installation fails on node v12. The problem is caused by levedown native module compilation failure. Leveldown is a dependency of level package and according to it readme it isn't support current node version.
Reproduce
npm i .
inside of repository directory.Solution
Upgrade level package to the latest version.
Checklist
level
tov6.0.0
.level-mem
tov6.0.0
here and intoethereumjs-blockchain
package, after monorepo migration.