Add a failing test for FakeTx.hash when from address is not specified

ethereumjs / ethereumjs-tx

Project is in active development and has been moved to the EthereumJS VM monorepo.

https://github.com/ethereumjs/ethereumjs-vm/tree/master/packages/tx

Mozilla Public License 2.0

779 stars 235 forks source link

Add a failing test for FakeTx.hash when from address is not specified #109

Closed frgtn closed 6 years ago

frgtn commented 6 years ago

Adds a failing test case for #108.

Also includes a trivial "fix" by changing default from address to 1.

coveralls commented 6 years ago

Coverage remained the same at 98.78% when pulling e94eb50a596b3042f1f5e5d14d9a07c8fe69db08 on frgtn:fake-tx-from-addr-failing-test-case into 2aa7e54d18de6ee1eaed61776bb58098641b4a37 on ethereumjs:master.

frgtn commented 6 years ago

Superseded by #110.