search

ethereumjs / ethereumjs-tx

Project is in active development and has been moved to the EthereumJS VM monorepo.
https://github.com/ethereumjs/ethereumjs-vm/tree/master/packages/tx
Mozilla Public License 2.0
779 stars 235 forks source link

Add tests for inherited FakeTransaction functions #114

Closed holgerd77 closed 5 years ago

holgerd77 commented 6 years ago

Test coverage for FakeTransaction is showing 100%. This is very misleading since all the inherited functionality stays untested from a FakeTransaction context.

There where different bugs introduced with recent updates https://github.com/ethereumjs/ethereumjs-tx/issues/108 or https://github.com/ethereumjs/ethereumjs-tx/issues/113 which could have been easily caught by expanding the test coverage.

Given the importance and wide usage of the FakeTransaction version these tests should be added on a high-priority.