Update official transaction tests to run with latest ethereumjs-testing (WIP)

ethereumjs / ethereumjs-tx

Project is in active development and has been moved to the EthereumJS VM monorepo.

https://github.com/ethereumjs/ethereumjs-vm/tree/master/packages/tx

Mozilla Public License 2.0

779 stars 235 forks source link

Update official transaction tests to run with latest ethereumjs-testing (WIP) #126

Closed danjm closed 5 years ago

danjm commented 5 years ago

fixes #115

Updates the transactionRunner.js tests as per the changes and instructions described here: https://github.com/ethereum/tests/issues/373

This is a work in progress. There are two things I need to verify:

that this test runner is covering all cases that the removed one covered
that the fact that no tests are failing due to EIP-155 is a problem on ethereum/tests

To do:

have the test properly handle command line args

coveralls commented 5 years ago

Coverage remained the same at 98.795% when pulling 4d8bc06dc858a70d20a61e452863450f8e488f59 on danjm:update-official-transaction-tests into e3fc21467ecb997090f63f154b1407094f173bf2 on ethereumjs:master.

holgerd77 commented 5 years ago

Cool that you are taking on this one, really needed!

danjm commented 5 years ago

closing in favour of #131 which is based off the main repo