Update and fix doc build

ethereumjs / ethereumjs-tx

Project is in active development and has been moved to the EthereumJS VM monorepo.

https://github.com/ethereumjs/ethereumjs-vm/tree/master/packages/tx

Mozilla Public License 2.0

781 stars 237 forks source link

Update and fix doc build #128

Closed danjm closed 5 years ago

danjm commented 5 years ago

This PR does two things:

updates the version of documentation.js so that the doc build can successfully run locally https://github.com/ethereumjs/ethereumjs-tx/commit/ef8e9059eea7ddcc4f511e39142655d0a95ab7ef
Makes some slight improvements to the index.js docs to clarify some behaviour that is added by ethereumjs-util https://github.com/ethereumjs/ethereumjs-tx/commit/602d7b489e0da0250f6cfe94ba4d97eb38aaf898

coveralls commented 5 years ago

Coverage remained the same at 98.795% when pulling 58f6b8003ecfd29a6bc5bed9061f335c58228a32 on danjm:update-and-fix-doc-build into c6f167e09535c62d482b8d9d0c45e20e47d9c70f on ethereumjs:master.

holgerd77 commented 5 years ago

Hi @danjm, please do work on a branch directly on the main repo, just wanted to rebase but can't, this would really be more convenient, also if others want to pick up on the work.

danjm commented 5 years ago

@holgerd77 I will work on the main repo directly from here out.

I have rebased this branch.