search

ethereumjs / ethereumjs-tx

Project is in active development and has been moved to the EthereumJS VM monorepo.
https://github.com/ethereumjs/ethereumjs-vm/tree/master/packages/tx
Mozilla Public License 2.0
779 stars 235 forks source link

Update Travis to run on Node v8 and v10; Add tests for inherited FakeTransaction functions #138

Closed chikeichan closed 5 years ago

chikeichan commented 5 years ago

Fixes #114

Opening this one on top of #131 - I will change merge target to master when #131 is merged.

coveralls commented 5 years ago

Coverage Status

Coverage remained the same at 98.936% when pulling 37cc36f0a52f3808cce8dcbd3f79239c143c4c80 on 114 into 8e425ec47032bf16db6d4d81df9b4b2a423439d4 on master.

holgerd77 commented 5 years ago

This has a linting error, also Node 6 is not supporting the spread operator. That said we have just decided to drop Node 6 support and you can use this PR to update CI to run towards Node 8, 10 and 11 (if you do can you then add a note to your initial PR description so that this won't get forgotten on release notes).

holgerd77 commented 5 years ago

One procedural note: can you use the PR-marked labels for your pull requests - primarily the WIP and Ready-for-review (only once tests passes) labels? Then it get's easier to judge if a PR is ready. You can also request specific reviewers if you like (not necessarily me).

holgerd77 commented 5 years ago

That said: thanks for the various PRs! 👍 😄

chikeichan commented 5 years ago

One procedural note: can you use the PR-marked labels for your pull requests - primarily the WIP and Ready-for-review (only once tests passes) labels? Then it get's easier to judge if a PR is ready. You can also request specific reviewers if you like (not necessarily me).

Thanks for the housekeeping notes @holgerd77 ! I will address the comments on various PRs over the next 3-5 days

holgerd77 commented 5 years ago

👍

holgerd77 commented 5 years ago

Hi @chikeichan can you bring this up-to-date?

alcuadrado commented 5 years ago

This looks good to me. The only method not directly tested is getSenderPublicKey, but it gets tested though getSenderAddress.

About the travis part. Should it include v11? It is the Current version now, but that'll change in a few weeks, and its EOL is in two months.