search

ethereumjs / ethereumjs-tx

Project is in active development and has been moved to the EthereumJS VM monorepo.
https://github.com/ethereumjs/ethereumjs-vm/tree/master/packages/tx
Mozilla Public License 2.0
779 stars 235 forks source link

Fix signing eip155 transactions #147

Closed holgerd77 closed 5 years ago

holgerd77 commented 5 years ago

I will open this new PR from the fix-signing-eip155-transactions branch which was displayed to me by GitHub. Can someone have a look and approve if considered to be side-effect-free to merge this again?

danjm commented 5 years ago

@holgerd77 This looks correct to me.

One tangible piece of verification: if we check the stats on the diff of this branch to master and https://github.com/alcuadrado/ethereumjs-tx/tree/typescript-migration to, we get an identical result. I did this locally.

Screenshot from 2019-04-29 08-20-16

holgerd77 commented 5 years ago

@danjm Cool 👍, thanks for checking! 😄

Will then merge here finally.

holgerd77 commented 5 years ago

@danjm @alcuadrado @s1na Respectively, can one of you guys explicitly approve here?

danjm commented 5 years ago

@holgerd77 Approved!