ethereumjs / ethereumjs-tx

Project is in active development and has been moved to the EthereumJS VM monorepo.
https://github.com/ethereumjs/ethereumjs-vm/tree/master/packages/tx
Mozilla Public License 2.0
779 stars 235 forks source link

Expose FakeTransaction named as FakeTransaction #156

Closed holgerd77 closed 5 years ago

holgerd77 commented 5 years ago

I think FakeTransaction in index.ts should be completely exposed as FakeTransaction and not just a shortened Fake. This name is not descriptive enough - this could point to various things - and especially in the context of tx instantiation we should be rather more precise. This is also confusing when looking at the documentation and seeing the fully written class name.

I thought twice about renaming the file names in src and test as well but then concluded this to be unnecessary and decided against. Can nevertheless update this as well if considered to be more consistent.