search

ethereumjs / ethereumjs-tx

Project is in active development and has been moved to the EthereumJS VM monorepo.
https://github.com/ethereumjs/ethereumjs-vm/tree/master/packages/tx
Mozilla Public License 2.0
779 stars 235 forks source link

Add github actions #184

Closed ryanio closed 4 years ago

ryanio commented 4 years ago

Incrementally adds Github Actions workflows. See how the checks look here.

closes #183

ryanio commented 4 years ago

WIP I need to investigate failing test: Error: Cannot convert string to buffer. toBuffer only supports 0x-prefixed hex strings and this string was given

holgerd77 commented 4 years ago

Failing test is due to the latest ethereumjs-util v6.2.0 release where we made the behavior of the toBuffer() function more strict (see Bug Fixes section), this was released recently and we decided to label this change as a bug fix (which might have been a mistake, not sure yet) and not a breaking change and therefore only changed the minor version, the tx library includes this by caret as ^6.0.0, so now uses this new version.

Eventually the error is only triggered within the test setup, but it might also be the case that the tx library is now generally broken after the util release. Then we would have to do a bug fix release here.

ryanio commented 4 years ago

Thanks, yeah I caught some of these before, just took changing from blank string '' to undefined to fix the single failing test 👍 opened PR here: #185