search

ethereumjs / ethereumjs-tx

Project is in active development and has been moved to the EthereumJS VM monorepo.
https://github.com/ethereumjs/ethereumjs-vm/tree/master/packages/tx
Mozilla Public License 2.0
781 stars 237 forks source link

Fix hash function #47

Closed fanatid closed 7 years ago

fanatid commented 7 years ago

Please review, merge and release ASAP.

coveralls commented 7 years ago

Coverage Status

Changes Unknown when pulling f1026311b2796a6da7938852bfd38496fc29a253 on fix/eip155-hash into on master.

coveralls commented 7 years ago

Coverage Status

Changes Unknown when pulling 304f934788dc204f0842c1843667d1f36c0f6fa1 on fix/eip155-hash into on master.

coveralls commented 7 years ago

Coverage Status

Changes Unknown when pulling 9614adf363b688098111ba9598f52b48c3ab4baa on fix/eip155-hash into on master.

wanderer commented 7 years ago

lgtm, @axic @kumavis can we get one more review?

kumavis commented 7 years ago

looks good to me 👍

kumavis commented 7 years ago

@wanderer please ver bump and publish

fanatid commented 7 years ago

@kumavis you in package owners on npmjs, so you also can do this :)

fanatid commented 7 years ago

I also recommend add message about wrong hash function to versions 1.2.0, 1.2.1, 1.2.2 with deprecate command

kumavis commented 7 years ago

oh! so i am! published as ethereumjs-tx@1.2.4 will also deprecate the old ones

kumavis commented 7 years ago

thanks @fanatid !