search

ethereumjs / ethereumjs-tx

Project is in active development and has been moved to the EthereumJS VM monorepo.
https://github.com/ethereumjs/ethereumjs-vm/tree/master/packages/tx
Mozilla Public License 2.0
781 stars 237 forks source link

EIP155 - allow v value to be greater than one byte #57

Closed kumavis closed 7 years ago

kumavis commented 7 years ago

Fixes #56 also see https://github.com/ethereum/EIPs/issues/155#issuecomment-276075645 https://github.com/ethereum/tests/issues/142

coveralls commented 7 years ago

Coverage Status

Changes Unknown when pulling 4bedffc8d721b5c7c784dadb00cf43e3121bad1f on eip155-fix into on master.

kumavis commented 7 years ago

@wanderer @axic

kumavis commented 7 years ago

Thank you @fanatid

fanatid commented 7 years ago

@kumavis still not clear for me from EIP thread, is standard allows chainId be multi-byte?

kumavis commented 7 years ago

de-facto standard -- its handled correctly by geth and parity

fanatid commented 7 years ago

Thank you. LGTM

coveralls commented 7 years ago

Coverage Status

Changes Unknown when pulling 2f79fa6fd8e316135dbd9a5866b42ec202a137aa on eip155-fix into on master.

kumavis commented 7 years ago

@wander plz bump and publish