search

ethereumjs / ethereumjs-tx

Project is in active development and has been moved to the EthereumJS VM monorepo.
https://github.com/ethereumjs/ethereumjs-vm/tree/master/packages/tx
Mozilla Public License 2.0
781 stars 237 forks source link

Move from explicit es2015 to babel preset env #86

Closed pgebheim closed 6 years ago

pgebheim commented 6 years ago

This is both the new fancy thing to do and ensures compatibility with node code that uses -env instead of explicit es201x.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 98.795% when pulling 3b7951cbc40507ec29c7cbc415f3e0c34d3c48ad on use-babel-preset-env into 80045d78dff14800693916e841eae045339cff37 on master.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 98.795% when pulling 3c76bafb107af801f66b44a8ba182ef81afea88c on use-babel-preset-env into a393b60d235ab02607c8425f931e3c0ffe30fb3b on master.

tinybike commented 6 years ago

Looks good to me!

tinybike commented 6 years ago

@wanderer if this looks okay to you, please merge + publish to npm when you get a chance :smile:

holgerd77 commented 6 years ago

Just rebased this.

tinybike commented 6 years ago

Is @wanderer still point man for this repo and for npm updates? Would be good to get this merged and pushed to npm!

holgerd77 commented 6 years ago

@tinybike I already asked Martin @wanderer some weeks ago, if npm publishing rights can be expanded to an active developer, e.g. @axic or me. Would you also be available for this? Will try to reach out to him again.

holgerd77 commented 6 years ago

@tinybike tried is the classic way, just sent an email. 😸

tinybike commented 6 years ago

Sounds good! Yes, I'd be more than happy to help keep this repo up-to-date. My npm username is tinybike.

axic commented 6 years ago

@holgerd77 since you understand babel way better, please feel free to merge.