search

ethereumjs / ethereumjs-tx

Project is in active development and has been moved to the EthereumJS VM monorepo.
https://github.com/ethereumjs/ethereumjs-vm/tree/master/packages/tx
Mozilla Public License 2.0
779 stars 235 forks source link

Add TS types to repo #88

Closed HenryNguyen5 closed 5 years ago

HenryNguyen5 commented 6 years ago

Related to https://github.com/ethereumjs/ethereumjs-wallet/pull/30

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 98.795% when pulling 64ef684ae3be73809cac053b2980ecfc74a5773c on HenryNguyen5:add-types into 80045d78dff14800693916e841eae045339cff37 on ethereumjs:master.

LogvinovLeon commented 6 years ago

Hi. I've just submitted ethereumjs-tx types to DefinitelyTyped https://www.npmjs.com/package/@types/ethereumjs-tx Those seem to be more complete though. Feel free to submit a PR to DT to fix that.

LogvinovLeon commented 6 years ago

Also - seems like this PR will have no effect unless you also have a types field in package.json

alcuadrado commented 5 years ago

I'm closing this PR. This project has been migrated to TypeScript 🎉

HenryNguyen5 commented 5 years ago

Awesome, nice job!