ethereumjs / ethereumjs-tx

Project is in active development and has been moved to the EthereumJS VM monorepo.
https://github.com/ethereumjs/ethereumjs-vm/tree/master/packages/tx
Mozilla Public License 2.0
779 stars 235 forks source link

'0x' should be automatically detected/prepended to transaction data #90

Closed jwasinger closed 5 years ago

jwasinger commented 6 years ago

Ran into this today and it took a little while to figure out because ethereumjs-tx was failing silently in this case. I'll see if there are other fields that have the same issue.

alcuadrado commented 5 years ago

Hi @jwasinger,

A possible fix local to this library was developed in #144, but after discussing it, we decided to fix this in ethereumjs-util. This alternative fix has already been merged but hasn't been released yet. You can take a look at it here: https://github.com/ethereumjs/ethereumjs-util/pull/197

alcuadrado commented 5 years ago

I'm closing this issue. If someone encounters this problem after version 2 is released please open a new issue.