units as json - Githubissues

ethereumjs / ethereumjs-units

Ethereum unit conversion.

MIT License

41 stars 19 forks source link

units as json #5

Closed fanatid closed 8 years ago

fanatid commented 8 years ago

It will more readable and you don't need disable key spacing for standard in this case

axic commented 8 years ago

Actually had it that way at some points, but thought having JSON.parse() just to use JSON would be a bit too much. Do you think its worth it?

fanatid commented 8 years ago

What do you mean? You don't need JSON.parse() for requiring json file -- require('./units.json').

axic commented 8 years ago

That's true, I am actually using it elsewhere. The only downside I think is the inability to have proper comments in JSON, otherwise it should be fine.