Removing native js dependency

ethereumjs / ethereumjs-util

Project is in active development and has been moved to the EthereumJS monorepo.

https://github.com/ethereumjs/ethereumjs-monorepo

Mozilla Public License 2.0

604 stars 274 forks source link

Removing native js dependency #257

Closed nebojsa94 closed 4 years ago

nebojsa94 commented 4 years ago

This PR removes keccak and secp256k1 dependencies and instead uses ethereum-cryptography package that doesn't require native dependency compiling

coveralls commented 4 years ago

Coverage decreased (-0.9%) to 98.854% when pulling 6a6af8ea5209d95fd17451e7b4165a203e10f602 on Tenderly:removing-native-js-dependency into 58c24765b6a30d4b331c3f1a7d974d669554f43a on ethereumjs:master.

coveralls commented 4 years ago

Coverage increased (+0.008%) to 99.711% when pulling ae77d7af4ab26babfdd48c1e10a4e3cdacadde64 on Tenderly:removing-native-js-dependency into d485939f3a868eec43af140d74ad9247a10f7320 on ethereumjs:master.

lgtm-com[bot] commented 4 years ago

This pull request introduces 1 alert when merging eda4d21cdbc3ba046037861b1b76451f251b9afd into 58c24765b6a30d4b331c3f1a7d974d669554f43a - view on LGTM.com

new alerts:

1 for Unused variable, import, function or class

holgerd77 commented 4 years ago

@nebojsa94 oh sorry, I merged in another PR https://github.com/ethereumjs/ethereumjs-util/pull/248, didn't expect this to conflict with this one. 😕 Could you give this a final update, I will directly merge this in afterwards.

@alcuadrado thanks for the review and the additional context. Should we directly publish this as v7.0.3 then I assume?

alcuadrado commented 4 years ago

Should we directly publish this as v7.0.3 then I assume?

Yep, this is the v7 version of these changes, so v7.0.3 should do.