search

ethereumjs / ethereumjs-util

Project is in active development and has been moved to the EthereumJS monorepo.
https://github.com/ethereumjs/ethereumjs-monorepo
Mozilla Public License 2.0
608 stars 273 forks source link

Add EIP-2098 support to work with compact 64-byte signatures #295

Closed k06a closed 3 years ago

k06a commented 3 years ago

https://eips.ethereum.org/EIPS/eip-2098

holgerd77 commented 3 years ago

@k06a hi there, cool, thanks for the PR 😄 . I could imagine that we are open for inclusion (a short pre-discussion wouldn't have been hurt either though, always some chance to get rejected which then leads to some frustration).

Short initial note: this repo is not active any more and Util has moved over to our monorepo https://github.com/ethereumjs/ethereumjs-monorepo. Please resubmit there for review and inclusion.

Thanks!

axic commented 3 years ago

@holgerd77 can this repo be marked archived or there are other reasons for it to be non-archived?

holgerd77 commented 3 years ago

@axic hmm, there is a semiish reason since we still have got the v4, v5 and v6 branches here which theoretically might need some bugfix release in the future. This hasn't happened for several months though and in doubt we can then also un-archive for a short amount of time. So will do, likely cleaner and less prone for confusion.

@k06a I will generally close here, would be great if you can resubmit to https://github.com/ethereumjs/ethereumjs-monorepo

Thanks! 😄