`.` in filename of v3 keystore files

ethereumjs / ethereumjs-util

Project is in active development and has been moved to the EthereumJS monorepo.

https://github.com/ethereumjs/ethereumjs-monorepo

Mozilla Public License 2.0

608 stars 274 forks source link

`.` in filename of v3 keystore files #83

Closed tayvano closed 7 years ago

tayvano commented 7 years ago

Anyone know if this has a purpose? I would like to remove it to address some user experience issues that are causing confusion on certain OS's, but want to ensure there wasn't a reason the file has a bizarre extension.

e.g.

UTC--2017-07-09T17-19-47.572Z--a4789ca05f7094186b1d1eb387d08856039d6284

would be

UTC--2017-07-09T17-19-47572Z--a4789ca05f7094186b1d1eb387d08856039d6284

fanatid commented 7 years ago

OOI, where I can read about keystore filename format? As I see parity@1.7.0 uses seconds without milliseconds https://github.com/paritytech/parity/blob/v1.7.0/ethstore/src/dir/disk.rs#L201-L202

axic commented 7 years ago

I think this is on the wrong repo as the function is in ethereumjs-wallet.

There is no spec for this, it is just a timestamp. I think it is a good idea not having dots in it.

tayvano commented 7 years ago

@axic Derp. Thanks for the info. When / if we update the filename, I'll ping you or PR in ethereumjs-wallet.