Packages.json needs to contain all the used packages

ethereumjs / ethereumjs-wallet

Utilities for handling Ethereum keys

MIT License

986 stars 295 forks source link

Packages.json needs to contain all the used packages #179

Open omardiaa opened 1 year ago

omardiaa commented 1 year ago

The following packages were not installed when I tried to install ethereumjs-wallet into my project:

stream
assert
buffer
crypto

Suggested change: Add the following to packages.json inside dependencies: "dependencies": { "assert": "^2.0.0", "buffer": "^6.0.3", "crypto": "^1.0.1", "stream": "^0.0.2" }

acolytec3 commented 1 year ago

Are you using this in browser? Those look like polyfills for NodeJS builtin modules used by this library and we wouldn't include those in our package.json since this library doesn't currently provide a browser-specific build (though not to say we can't explore that).