search

ethereumjs / ethereumjs-wallet

Utilities for handling Ethereum keys
MIT License
986 stars 295 forks source link

Create tests to achieve 100% coverage #26

Open axic opened 6 years ago

axic commented 6 years ago

A couple of simple tests can be added to cover index.js (except the fromV1 function). Covering thirdparty.js is secondary.

holgerd77 commented 6 years ago

Not sure if I find some time but if so would it be ok to directly push some additional tests to the dependency-update PR https://github.com/ethereumjs/ethereumjs-wallet/pull/25?

axic commented 6 years ago

I'd create a new PR off that. Want to merge #25 once ethereumjs-util 5.1.4 is released.

stvtortora commented 4 years ago

Hey, do you still need help with this issue? I'd bee happy to take it.

alcuadrado commented 4 years ago

Hey @stvtortora! Help on this would be great!

According to coveralls, the third party module is the least tested. It contains utility functions to encode/decode wallets generated by different apps.

Let me know if you need help with this.

holgerd77 commented 4 years ago

Hi @stvtortora that's nice, thanks for the offer! 😄 Please be aware of this open PR https://github.com/ethereumjs/ethereumjs-wallet/pull/86 from @chikeichan. We forgot a bit about that unfortunately, but would be nice if we would get this updated and merged along.