search

ethereumjs / keythereum

Create, import and export Ethereum keys
MIT License
609 stars 163 forks source link

Fixed error handling in importFromFile in case the file doesn't exist #60

Closed aleybovich closed 6 years ago

aleybovich commented 6 years ago

Returning the error instead of throwing it makes it impossible to actually handle that error.

aleybovich commented 6 years ago

@tinybike can you please take a look? This is a critical bug for my project. Thank you!

tinybike commented 6 years ago

@aleybovich This should be fixed by https://github.com/ethereumjs/keythereum/pull/63 -- see #59 for discussion! Closing this for now.