search

ethereumjs / keythereum

Create, import and export Ethereum keys
MIT License
609 stars 163 forks source link

Remove package-lock.json file #72

Closed whymarrh closed 5 years ago

whymarrh commented 5 years ago

This PR removes the package-lock.json file from the library. Libraries don't need to have their dependencies locked to specific versions (similar to #71) and what's worse is that having a package-lock.json file prevents the library from being tested against minor and patch bumps (once #71 is resolved).

I've added the file to the .gitignore for future installs.

whymarrh commented 5 years ago

See also https://github.com/ethereumjs/merkle-patricia-tree/pull/62#issuecomment-443293041

holgerd77 commented 5 years ago

Hey guys, maybe put it a bit on hold with merging stuff here, since @tinybike has the operational authority here.

@tinybike is it ok if we (EF EthereumJS team) do active work here respectively also do structural decisions on the library?

chikeichan commented 5 years ago

Got it - I approved the PR based on comments made on this thread back in December, and I was under the impression that the decision was extended to all repos in the github org.

I will err on the side of caution when reviewing/approving structural changes going forward.