Add support for async/await in addition to callbacks

ethereumjs / keythereum

Create, import and export Ethereum keys

MIT License

609 stars 163 forks source link

Add support for async/await in addition to callbacks #76

Closed chikeichan closed 1 week ago

chikeichan commented 5 years ago

Fixes #58

[x] Promisfy deriveKeyUsingScryptInNode
[x] Promisfy deriveKeyUsingScryptInBrowser
[x] Promisfy deriveKey
[x] Promisfy create
[x] Promisfy dump
[x] Promisfy recover
[x] Promisfy exportToFile
[x] Promisfy importFromFile
[x] Add tests for all new promise use case

chikeichan commented 5 years ago

@whymarrh would love your opinion here - this PR add support for Promises, but the codebase uses es5 and browserify. Is it necessary to add babelify for promise polyfills? Since this is a library, I am thinking that most users would bundle it again with the polyfills.