search

ethereumjs / keythereum

Create, import and export Ethereum keys
MIT License
609 stars 163 forks source link

New CHANGELOG #82

Closed holgerd77 closed 3 years ago

holgerd77 commented 3 years ago

@tinybike ah, just discovered that you already released. Was a bit confused since I had already prepared a release PR as well, then I will now just submit the new CHANGELOG file from this.

One question: also confused a bit that dist and keystore folders are included in your v1.2.0 release but at the same time also included in .npmignore, so when I did npm pack these folders were actually omitted. Can we remove these from .npmignore therefore? Or is there otherwise a special "trick" to do releases? 😄

tinybike commented 3 years ago

Ah, sorry @holgerd77, I didn't mean to scoop you! Just figured I'd go ahead and do a release while I was thinking about it.

The dist folder is just there so that people can drop keythereum directly into the browser if they want to via script tag, e.g.

<script src="dist/keythereum.min.js" type="text/javascript"></script>

So, I think that dist doesn't need to be part of the npm release, even though it is called dist and is created using npm run build. I guess this is a bit confusing, sorry about that!

The keystore folder is only there to hold keystore files for testing, so I think it's also not needed in the npm release.