Replaced crypto-browserify with browserify-aes, which is a dependency of crypto-browserify; without all the unnecessary modules. We are still using browserify-aes because the keythereum's related api methods are synchronous - ethereum-cryptography/aes exposes async-only methods, I didn't want to change API
Replaced keccak with ethereum-cryptography/keccak
Replaced scrypt-js with ethereum-cryptography/scrypt. NOTE: tests were failing after that because EC's scrypt conforms to RFC7914 section 2, which prohibits N: 262144, p: 8, r: 1. The old version did not conform to spec. My guess is that someone at some point messed up the tests and passed p: 8, r: 1 instead of r: 8, p: 1, which is standard.
Replaced secp256k1 with ethereum-cryptography/secp256k1-compat
Removed sjcl which had pbkdf2 implementation - we are using EC's one
Updated uuid from 3.0.0 to 8.3.2
The package versions are exact, like before - no version ranges
wc < dist/keythereum.js output:
before 31994 118030 921363
after 15243 63140 484003
Backwards incompatibilities:
BigInt support is now required
keythereum.crypto is now an emulated object instead of crypto-browserify stuff: i've searched GitHub for its usage and those seem to be the only used methods; I think it'll be good
crypto-browserifywithbrowserify-aes, which is a dependency of crypto-browserify; without all the unnecessary modules. We are still usingbrowserify-aesbecause the keythereum's related api methods are synchronous - ethereum-cryptography/aes exposes async-only methods, I didn't want to change APIkeccakwithethereum-cryptography/keccakscrypt-jswithethereum-cryptography/scrypt. NOTE: tests were failing after that because EC's scrypt conforms to RFC7914 section 2, which prohibitsN: 262144, p: 8, r: 1. The old version did not conform to spec. My guess is that someone at some point messed up the tests and passedp: 8, r: 1instead ofr: 8, p: 1, which is standard.secp256k1withethereum-cryptography/secp256k1-compatsjclwhich had pbkdf2 implementation - we are using EC's oneuuidfrom 3.0.0 to 8.3.2wc < dist/keythereum.jsoutput:31994 118030 92136315243 63140 484003Backwards incompatibilities:
keythereum.cryptois now an emulated object instead ofcrypto-browserifystuff: i've searched GitHub for its usage and those seem to be the only used methods; I think it'll be good