search

ethereumjs / organization

A repo for discussions and other non-code organizing stuff
https://ethereumjs.readthedocs.io
12 stars 16 forks source link

Coveralls - Introduce decrease and absolute failure thresholds #22

Closed holgerd77 closed 5 years ago

holgerd77 commented 6 years ago

Just discovered that Coveralls allows for both decrease and absolute thresholds (on the project settings page) for indicating failure on CI runs.

I've now set the descrease failure threshold to 0.5% for the VM, since in practice many PRs are displayed as failure just because of tiny coverage decreases, which limits the meaningfulness of build overviews.

This should be done for the different libraries with a practical threshold. There probably should also be inserted an absolute threshold to encourage to stay above a desired limit.

axic commented 6 years ago

Good call, agreed.

holgerd77 commented 5 years ago

Have done this over time for many/most of the libraries and will add if something is still missing, no need for a separate issue any more to track, will close.