search

ethereumjs / organization

A repo for discussions and other non-code organizing stuff
https://ethereumjs.readthedocs.io
12 stars 17 forks source link

Missing labels for new labelling system (round 2) #41

Closed holgerd77 closed 2 days ago

holgerd77 commented 5 years ago

Some more collection on labels, since I stumbled upon one I would very much like to integrate. Will eventually do a third integration round within a couple of weeks.

holgerd77 commented 5 years ago

An eval: needs analysis label would very much complement the current eval type labels.

Sometimes/often issues require a large amount of extra thought/analysis work before one can start to code. A dedicated label makes it more explicit that this is actually a significant separate work step before coding (which can also very well be taken on by a different person). This should to some extend ease the path towards the final implementation.

holgerd77 commented 4 years ago

Sometimes missing effort: E0 minutes and effort: E5 years

Use case example for effort: E0 minutes: https://github.com/ethereumjs/ethereumjs-vm/issues/912

ryanio commented 4 years ago

Suggestion: PR: breaking change

holgerd77 commented 4 years ago

Missing a type: maintenance label, example case: https://github.com/ethereumjs/ethereumjs-client/issues/149

evertonfraga commented 3 years ago

I have opened a PR with @holgerd77 's new type label.

@ryanio how about we use it like type: breaking change? Because it doesn't quite fit on the PR states category.