Fixes in labels - Githubissues

ethereumjs / organization

A repo for discussions and other non-code organizing stuff

https://ethereumjs.readthedocs.io

12 stars 17 forks source link

Fixes in labels #58

Closed evertonfraga closed 4 years ago

evertonfraga commented 4 years ago

[ ] Labels for monorepo packages
[x] Order of priority labels — use zero-index, because we're programmers :-) (see image 1)
[x] Unifies label colors (see image 2)

holgerd77 commented 4 years ago

Ah sorry, re-open, didn't see the other tasks in the task list.

holgerd77 commented 4 years ago

The differing in the bounty color is also on purpose, since this is logically somewhat a shift from the other bounty labels. The darker colors indicate the process, the one lighter is more somewhat of an additional tagging.

holgerd77 commented 4 years ago

TBH I also find this zero-index change a bit over the top, this is causing a lot of work to adopt in all the repos, benefits are limited and at the end this is just some question of taste.

evertonfraga commented 4 years ago

Right! moving urgent to P0 would be convenient as it would require changes in only one label :-)

Thanks for the context. So I'll close it for now.

I'll make the third set of changes (monorepo) in a separate PR, so I keep things clean.

holgerd77 commented 4 years ago

The package labels doesn't really need to be added here, since they are just for the one monorepo, so should just be enough to add them there directly shouldn't it? This can't be reused or is some kind of a standard anyhow.