Multi-geth integration bugfixes

ethereumproject / evm-rs

Ethereum Virtual Machine implementation in Rust. Fork of the SputnikVM.

Apache License 2.0

14 stars 5 forks source link

Multi-geth integration bugfixes #22

Closed mersinvald closed 5 years ago

mersinvald commented 5 years ago

Integration into Multi-Geth and full run of ETH test suite revealed some bugs that were not caught before.

This PR fixes these bugs.

Closes #3,#4,#5,#6,#7,#8,#9,#10,#11,#12,#13,#14,#15,#16,#17,#18

r8d8 commented 5 years ago

@mersinvald I would suggest to have separate PR for an issue in a future. It's a bit confusing to match changes to the concrete issue.

mersinvald commented 5 years ago

@r8d8 yes, I agree, that would be better, it's pretty hard to make sense of the full diff. Individual commits are mostly atomic to one single fix each, maybe that'll help?

jakelang commented 5 years ago

@mersinvald can these fixes get unit tests as well?

mersinvald commented 5 years ago

@jakelang yeah, good idea, please make an issue for that, that's exactly what regtests are for.