Because of the singleton-like nature of LLVM types, we cannot compare the argument types to new type instances. We instead borrow from the EvmTypes singleton (from which the function signature itself was built), so that the internal type references match up.
Because adding an attribute to a function value accepts an Attribute by value, it is not currently possible to make the internal references of the test attribute and the function's attribute match up. Instead, we compare the attribute kind IDs.
What still needs to be fixed:
Tests randomly segfaulting
Tests displaying probabilistic behavior (Sometimes free_func.count_params() will incorrectly display 2 arguments. Furthermore, even before this fix, tests would occasionally randomly pass.)
This PR does two things:
EvmTypessingleton (from which the function signature itself was built), so that the internal type references match up.Attributeby value, it is not currently possible to make the internal references of the test attribute and the function's attribute match up. Instead, we compare the attribute kind IDs.What still needs to be fixed:
free_func.count_params()will incorrectly display2arguments. Furthermore, even before this fix, tests would occasionally randomly pass.)