Closed NT7S closed 7 years ago
How about doing it like some of the Si570 libraries does it, where if the change deltaF is less than a given value, lets say 10KHz you do not reset?this way, the tuning should appear continous for small changes where its clearly visible, yet for larger changes, and bandswitching, the discontinuty would be once.
2017-04-10 17:58 GMT+02:00 Jason Milldrum notifications@github.com:
When using the library in a receiver, there are reports that the CLK output has a discontinuity when the frequency is changed, causing an audible popping in the audio.
It is known that this is the result of the PLL reset in the tuning code, which is sometimes needed to ensure that the output is on the correct frequency. What is needed is a way to minimize these PLL resets to avoid this problem as much as possible.
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/etherkit/Si5351Arduino/issues/44, or mute the thread https://github.com/notifications/unsubscribe-auth/AEOGvHpp1jR8hsueAem7do-mQdoyif6Eks5rulGegaJpZM4M4-rM .
--
Please avoid sending me Word or PowerPoint attachments. See http://www.gnu.org/philosophy/no-word-attachments.html PDF is an better alternative and there are always LaTeX!
I need to do some testing into exactly when it is required for the PLL to be reset in the course of changing the multisynth parameters. I believe at a minimum it should be feasible to suppress PLL reset across an amateur radio band, and perhaps under even more circumstances.
but why ver 202 works without clicks?
MAc sp9mrn
2017-04-10 18:11 GMT+02:00 Jason Milldrum notifications@github.com:
I need to do some testing into exactly when it is required for the PLL to be reset in the course of changing the multisynth parameters. I believe at a minimum it should be feasible to suppress PLL reset across an amateur radio band, and perhaps under even more circumstances.
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/etherkit/Si5351Arduino/issues/44#issuecomment-292998470, or mute the thread https://github.com/notifications/unsubscribe-auth/AHsBJ6zwIvJ9NtfWF5HX0xpo45QA8y7qks5rulTNgaJpZM4M4-rM .
@sp9mrn The PLL reset wasn't in the set_freq() method previous to that (well it was in an earlier version but had been removed for a while):
" I believe at a minimum it should be feasible to suppress PLL reset across an amateur radio band" - yes, but we have to describe condition "across band" without wasteing time for calaculating it (the frequencies) from IF&VFO. What does it mean for controller "you are still inside band" without checking "changeband' state? For my brain it's easy ;-) We can of course chceck "band NR" or "changeband" variable, but it is good for sketch, not for library. Thanks for Your work ;-) MAc
Please visit and test this lib https://github.com/pavelmc/Si5351mcu it does not have click noise.
The trick is to just make a reset of the PLLs just when it's needed; and that is at the initialization on a sweetsop frequency (in the setup() procedure) then you recalculate the PLLs and msynths and just update them, it will work 100%
Also my correction procedure do make click noise as I have to reset the IC after any XTAL freq change
I have published it yesterday and had it test about ~1 month now in this project: https://github.com/pavelmc/arduino-arcs with click free operation in my bench and tested and confirmed the click-less operation by at least 2 more users. (The lib was made up in the last weekend, the code is embedded on the project files since a few time now)
The test I made has revealed (see lib example) that I can move the freq from 25 to 150 Mhz without resetting the PLL/msynths and it hasn't any secondary effect against the same run resetting on every freq change (beside click-less operation)
I has made it run trough 1 to 10 Mhz also and it perform the same with/without resetting.
73 de Pavel CO7WT.
PS: There is at least one report that the lib do has click noise, but it may be from hardware setup conditions, I'm digging about it and waiting for more reports to confirm, the lib has just one day of life.
I just pushed a branch where all I did was comment out the PLL reset. I'd like to see if there are instances where tuning fails under these circumstances, so if those of you having tuning problems can please try this out and let me know how it works, it would be appreciated. To try it out, manually install the library in your Arduino installation.
Works with no clicks for me - thanks for the effort 73 De M0DGB
Sound of silence. Wonderful. I checked only in range of 300kHz. I suppose I can call PLLreset with "bandchange" command if necessary. Thank You
Fixed by #48
When using the library in a receiver, there are reports that the CLK output has a discontinuity when the frequency is changed, causing an audible popping in the audio.
It is known that this is the result of the PLL reset in the tuning code, which is sometimes needed to ensure that the output is on the correct frequency. What is needed is a way to minimize these PLL resets to avoid this problem as much as possible.