The comments in the title block of SI5351.set_freq(freq, clk) say freq units are Hz. I think they are Hz*100ULL.

etherkit / Si5351Arduino

Library for the Si5351 clock generator IC in the Arduino environment

GNU General Public License v3.0

229 stars 94 forks source link

The comments in the title block of SI5351.set_freq(freq, clk) say freq units are Hz. I think they are Hz*100ULL. #97

Open frohro opened 3 months ago

frohro commented 3 months ago

This is on line 180 of si5351.cpp. I believe the same issues occur with SI5351.set_freq_manual and probably other functions should be checked. This is important as VScode and other IDEs display those comments when you hover over the function call.

NT7S commented 3 months ago

Thank you, I'll fix this in the next update, which shouldn't be too long now that I've got a lab again.

frohro commented 3 months ago

Thanks!